Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier tables #2

Closed
wants to merge 1 commit into from
Closed

Prettier tables #2

wants to merge 1 commit into from

Conversation

juan518munoz
Copy link

@juan518munoz juan518munoz commented Nov 24, 2023 •
edited
Loading

This pull request is just a QoL change to have a better table printed on the terminal, that supports wrapping content to fit on the current terminal width.

image
image
image

Made using comfy_table.

igamigo
igamigo reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make sure tabled is no_std compatible (for what I could see from looking at the crate docs, some types of tables are and some are not)

@juan518munoz
Copy link
Author

As you mentioned, tabled has a no std table, CompactTable, it can't be used due to the fact that to print it on terminal it depends on being first transformed into String, said method depends on std.

For this reason I switched the crate to cli_table, that is no std compatible.

@bobbinth @juan518munoz
Initial commit
86b39cb 
feat: set up client structure

add command skeleton and table migrations

lints and remove testing prints

fmt]

add log to crate

testing feature so that PoW in seed grinding does not take long

addressing reviews

map_err

fix deserialization

remove further unwraps

add test

address further reviews

use new functions

address reviews

prettier table

replace tabled with no std alt

add SQL relations

align comments

feat: add github ci workflow

feat: introduce input notes db and list command

prettier wrapping table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igamigo igamigo igamigo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan518munoz @igamigo @bobbinth