Add locking to avoid race conditions in cache #118
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
force-pushed
the
cache-rpc-safe
branch
from
0fec0c6 to
918f033
Compare
JulianGCalderon
force-pushed
the
cache-rpc-safe
branch
from
918f033 to
6407ab4
Compare
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
fmoletta,
pefontana and
gabrielbosio
as code owners
FrancoGiachetta
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if two replay instances execute the same block at the same time, race conditions can appear when writing to the cache, corrupting it's state.
This PR fixes it by using file locks to ensure that only one process modifies the cache at a time.
I added fs2 as a dependency, as the file lock API of the standard fs crate is nightly only.