Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid account signature #132

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Fix invalid account signature #132

merged 4 commits into from
Jan 24, 2025

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Jan 23, 2025 •
edited
Loading

Depends on lambdaclass/sequencer#44

Some transactions reverted due to invalid account signature, both in Native and VM.

This PR changes two things that fixed the issue:

  • Using sequencer's ChainId, rather than our RpcChain
  • Using the appropiate versioned contants, according to the transactions starknet version, rather than using always the latest ones.

@JulianGCalderon JulianGCalderon force-pushed the reuse-sequencer-elements branch from 9a4e049 to e4999bf Compare January 23, 2025 21:23
@JulianGCalderon JulianGCalderon force-pushed the reuse-sequencer-elements branch from fc51e77 to 6050e4c Compare January 24, 2025 13:41
@JulianGCalderon JulianGCalderon marked this pull request as ready for review January 24, 2025 14:43
@JulianGCalderon JulianGCalderon added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 8f3d534 Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoGiachetta FrancoGiachetta FrancoGiachetta approved these changes

@azteca1998 azteca1998 azteca1998 approved these changes

@edg-l edg-l Awaiting requested review from edg-l edg-l is a code owner

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@gabrielbosio gabrielbosio Awaiting requested review from gabrielbosio gabrielbosio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianGCalderon @azteca1998 @FrancoGiachetta