Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen client extra features merge main #389

Merged

Conversation

gianbelinche
Copy link

What ❔

Merges last main commits to extra features

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

tomg10 and others added 21 commits January 23, 2025 17:52
…labs#3521)

Current defaults for EN for gas estimation are different from values
used everywhere, this PR addresses that problem
…#3454)

Adding repeated runs of integration tests for easier tracking of tests
flakiness. A single such check takes ~1h and should cost ~2$, which imo
is more than acceptable
## What ❔

Temporary return to path cross-workspace dependencies before we publish
everything to crates.io.

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

Co-authored-by: perekopskiy <[email protected]>
## What ❔

Load compressor setup data from the right dir

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
🤖 I have created a release *beep* *boop*
---


##
[26.2.0](matter-labs/zksync-era@core-v26.1.0...core-v26.2.0)
(2025-01-24)


### Features

* Compressor optimizations
([matter-labs#3476](matter-labs#3476))
([3e931be](matter-labs@3e931be))


### Bug Fixes

* **en:** better defaults, i.e. the same as used by main node
([matter-labs#3521](matter-labs#3521))
([2b5fe98](matter-labs@2b5fe98))
* **en:** Fix race condition in EN storage initialization
([matter-labs#3515](matter-labs#3515))
([c916797](matter-labs@c916797))
* JSON proof serialization
([matter-labs#3514](matter-labs#3514))
([516e521](matter-labs@516e521))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Co-authored-by: Anton Baliasnikov <[email protected]>
🤖 I have created a release *beep* *boop*
---


##
[18.0.0](matter-labs/zksync-era@prover-v17.1.1...prover-v18.0.0)
(2025-01-27)


### ⚠ BREAKING CHANGES

* **contracts:** gateway integration
([matter-labs#1934](matter-labs#1934))

### Features

* Compressor optimizations
([matter-labs#3476](matter-labs#3476))
([3e931be](matter-labs@3e931be))
* **consensus:** Added view_timeout to consensus config
([matter-labs#3383](matter-labs#3383))
([fc02a8f](matter-labs@fc02a8f))
* **consensus:** Update consensus dependencies
([matter-labs#3339](matter-labs#3339))
([aa9575f](matter-labs@aa9575f))
* **contracts:** gateway integration
([matter-labs#1934](matter-labs#1934))
([f06cb79](matter-labs@f06cb79))
* **eth-watch:** Change protocol upgrade schema
([matter-labs#3435](matter-labs#3435))
([2c778fd](matter-labs@2c778fd))
* FFLONK support for compressor
([matter-labs#3359](matter-labs#3359))
([1a297be](matter-labs@1a297be))
* Support stable compiler for VM (and some other crates)
([matter-labs#3248](matter-labs#3248))
([cbee99d](matter-labs@cbee99d))


### Bug Fixes

* added missing quote in prover query
([matter-labs#3347](matter-labs#3347))
([668ca51](matter-labs@668ca51))
* Compressor setup data
([matter-labs#3526](matter-labs#3526))
([62aea8b](matter-labs@62aea8b))
* **prover:** Create reqwest client only once
([matter-labs#3324](matter-labs#3324))
([40f8123](matter-labs@40f8123))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
…ter-labs#3486)

## What ❔

* Updating info on v25 and v26 (they are the same as v24.1)
* Cleaned up README
…e dev environments, and improve reproducibility (matter-labs#3524)

## What ❔

- Introduced new functionalities via `zkstack.nix` and
`foundry-zksync.nix`.
- Optimized the `zksync` and `tee_prover` builds with clear sandboxing
options and improved handling of files.

## Why ❔

- Updated `flake.nix` and other dependencies to ensure improved
compatibility and reproducibility.
- Enhanced development environment with `devShellAll.nix` for a full
stack.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Signed-off-by: Harald Hoyer <[email protected]>
…labs#3436)

## What ❔

Largely removes `zkstack` dependency on `zksync_config`.

## Why ❔

This dependency significantly complicates new config system integration.
While the alternative is less typesafe, it can be made more typesafe in
the future once the config system integration is complete (a node binary
can then be used to validate the changed config values).

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
## What ❔

dummy change to trigger release-please PR

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
…for 5 minutes (matter-labs#3299)

We have
[this](https://github.com/matter-labs/gitops-kubernetes/blob/main/apps/environments/raas-abstract-testnet/server-v2/server-v2-core.yaml#L185)
alert:

```
      no_eth_watch_iterations:
        promql: max(rate(server_eth_watch_eth_poll[30s]))
        compare: "=="
        thresholds:
          critical: 0
        duration: 5m
        annotations:
          description: "No ETH watch iterations for 5 minutes"
          summary: "No ETH watch iterations for 5 minutes"
          runbook_url: "https://www.notion.so/matterlabs/On-Call-1d597d29c9b64c08919bf53c952cd03e?pvs=4#78da3253ab3e41aa8175e72caf456c86"
```

But we reported this `server_eth_watch_eth_poll` metric on every
iteration - even if it wasn't successful. This PR changes the logic so
that it's only reported when successful - meaning that we will be
alerted if there was no successful iterations for five minutes.

We may want to increase the threshold to something like 10 minutes to
avoid being notified at transient L1 provider issues.

Co-authored-by: Tomasz Grześkiewicz <[email protected]>
🤖 I have created a release *beep* *boop*
---


##
[26.2.1](matter-labs/zksync-era@core-v26.2.0...core-v26.2.1)
(2025-01-28)


### Bug Fixes

* add . to readme
([matter-labs#3538](matter-labs#3538))
([512dd45](matter-labs@512dd45))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Co-authored-by: perekopskiy <[email protected]>
This PR contains EN improvements and fixes based on most often asked
partner's questions
## What ❔

Add new metrics to the da_dispatcher:
- sealed -> dispatched lag
- operator balance

## Why ❔

To improve transparency and be able to create alerts based on these
values

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
## What ❔

Fixes a path to the prover data handler port.

## Why ❔

Without this fix, the prover gateway config is set up incorrectly.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
A lot of prover infra relies on tracing. Tracing is not available on all
environments. As such, troubleshooting issues covered by tracing is not
possible. A recent service degradation could not be troubleshot due to
lack of tracing. This line enables troubleshooting even when tracing is
not available.

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
@gianbelinche
Copy link
Author

Do not squash

Copy link

github-actions bot commented Jan 30, 2025

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Eigen client extra features merge main". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@gianbelinche gianbelinche merged commit 2116030 into eigen-client-extra-features Jan 30, 2025
6 of 27 checks passed
@gianbelinche gianbelinche deleted the eigen-client-extra-features-merge branch January 30, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.