forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eigen-client-extra-features): Merge main and update contracts #394
Merged
gianbelinche
merged 8 commits into
eigen-client-extra-features
from
eigen-client-extra-features-update-contracts
Feb 4, 2025
Merged
feat(eigen-client-extra-features): Merge main and update contracts #394
gianbelinche
merged 8 commits into
eigen-client-extra-features
from
eigen-client-extra-features-update-contracts
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atter-labs#3527) Fixes matter-labs#3190 Fixes matter-labs#3309 I still have to test the migration logic (want to make sure that Era mainnet data can be migrated correctly & quickly), but the PR is reviewable otherwise. This one is much bigger than I indended it to be, sorry 🥲 - Changes `zksolc` used in contract verifier tests to 1.5.10 (old one didn't have `ipfs` metadata hash support). - Fixes problems that occured with newer compilers (e.g. `Yul` bytecode extraction). - Makes it easier to run contract verifier tests locally (pins compiler versions, so that if you have a lot of compilers locally, tests don't crash). - Introduces partial matching for contracts - Reworks the schema so that contracts with matching bytecode can be "automatically" verified. - Adds a migration to the new table.
…uous mode (matter-labs#3555) ## What ❔ Allow witness_generator to use Prometheus push gateway in continuous mode. Log which metrics method is used on start. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ To keep receiving metrics in any running mode. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: EmilLuta <[email protected]>
…atter-labs#3529) ## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Dima Zhornyk <[email protected]> Co-authored-by: dimazhornyk <[email protected]>
## What ❔ Allows caching signature verification (more precisely, `ecrecover` output for L2 transactions using the default AA) in the fast VM. ## Why ❔ Signature verification takes ~50% of the execution time for "simple" transactions (e.g., base token and ERC-20 token transfers), so caching it may improve performance. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ Move specified WG DAL methods to separate files. Some of the methods are unified, so they are left as is, but can be reworked as well in a follow-up(since it might require another thousand lines of changes). ## Why ❔ To improve readability(the previous file was 2000 lines of code and it's hard to understand at least something there) ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Do not squash this PR |
4 tasks
juanbono
approved these changes
Feb 4, 2025
4 tasks
juan518munoz
approved these changes
Feb 4, 2025
ca4f11a
into
eigen-client-extra-features
9 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmt
andzkstack dev lint
.