Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.4 in laminas-cache-storage-adapter-filesystem 2.x #103

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

driehle
Copy link
Contributor

@driehle driehle commented Jan 22, 2025

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This MR falls in the context of adding support for PHP 8.4 to laminas-cache v3. Adding support to the legacy version is essential, as laminas-cache v4 requires servicemanager v4 and many users cannot yet migrate to servicemanager v4, as quite a few packages in the MVC ecosystem yet lack support for servicemanager v4.

More information available here:

Signed-off-by: Dennis Riehle <[email protected]>
@froschdesign
Copy link
Member

@driehle

See: https://github.com/amphp/amp/releases/tag/v2.6.4

"conflict": {
    "amphp/amp":"<2.6.4"
}

@driehle driehle marked this pull request as ready for review January 22, 2025 11:03
@driehle
Copy link
Contributor Author

driehle commented Jan 22, 2025

Thanks for the hint, @froschdesign. Upgrade of PHPUnit was needed nontheless, both PHPUnit an AMP were triggering deprecations.

Signed-off-by: Dennis Riehle <[email protected]>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @driehle

@gsteel gsteel self-assigned this Jan 23, 2025
@gsteel gsteel merged commit d1777b7 into laminas:2.5.x Jan 23, 2025
17 checks passed
@driehle driehle deleted the feat/php84 branch January 23, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants