Allow PHP 8.4 in laminas-cache-storage-adapter-redis 2.x #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Riehle <[email protected]>
|
@froschdesign Any idea why CI is not running here? Does it need approval from your side? Edit: Nevermind. The second push triggered CI. Not sure why the first push didn't trigger CI though... |
|
Edit: This seems indeed to be the case. The release notes of phpredis 6.1.0 mention the following:
|
driehle
force-pushed
the
feat/php84
branch
3 times, most recently
from
789c034 to
1a9693b
Compare
Signed-off-by: Dennis Riehle <[email protected]>
driehle
force-pushed
the
feat/php84
branch
2 times, most recently
from
30534bd to
12f3df7
Compare
Signed-off-by: Dennis Riehle <[email protected]>
Signed-off-by: Dennis Riehle <[email protected]>
This was referenced Jan 22, 2025
gsteel
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR falls in the context of adding support for PHP 8.4 to laminas-cache v3. Adding support to the legacy version is essential, as laminas-cache v4 requires servicemanager v4 and many users cannot yet migrate to servicemanager v4, as quite a few packages in the MVC ecosystem yet lack support for servicemanager v4.
More information available here: