Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop built-in middleware support in favor of laminas-mvc-middleware #54

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Drop built-in middleware support in favor of laminas-mvc-middleware #54

merged 3 commits into from
Jun 3, 2022

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Jun 9, 2020

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

This PR removes all bits for optional middleware pipe support in favor of using laminas/laminas-mvc-middleware

Related to #51
Depends on #50

@Xerkus Xerkus added the BC Break label Jun 9, 2020
Xerkus added a commit to Xerkus/laminas-mvc that referenced this pull request Jun 9, 2020
@Xerkus
Add CHANGELOG for laminas#54
834174a 
Signed-off-by: Aleksei Khudiakov <[email protected]>
@Xerkus Xerkus changed the title Drop optional middleware support in next major Drop built-in middleware support in favor of laminas-mvc-middleware Jun 9, 2020
@Xerkus Xerkus added this to the 4.0.0 milestone Jun 12, 2020
@Xerkus Xerkus force-pushed the feature/drop-middleware branch from 3831f78 to 834174a Compare June 12, 2020 12:25
@geerteltink geerteltink changed the base branch from next to 4.0.x September 12, 2020 09:03
Xerkus added a commit to Xerkus/laminas-mvc that referenced this pull request Apr 9, 2021
@Xerkus
Add CHANGELOG for laminas#54
0aedced 
Signed-off-by: Aleksei Khudiakov <[email protected]>
@Xerkus Xerkus force-pushed the feature/drop-middleware branch from 834174a to 0aedced Compare April 9, 2021 19:28
@Xerkus Xerkus changed the base branch from backup-4.0.x-at-2022-02-24 to 4.0.x June 3, 2022 12:16
@Xerkus Xerkus force-pushed the feature/drop-middleware branch from 0aedced to bccdca7 Compare June 3, 2022 12:16
@Xerkus Xerkus requested review from a team and removed request for a team June 3, 2022 13:03
weierophinney
weierophinney requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and we've discussed it before in the TSC.

My only change request is that you create a migration chapter in the documentation that indicates that the MiddlewareListener has been moved to laminas/laminas-mvc-middleware, and link to that package (preferably to its documentation).

@Xerkus Xerkus force-pushed the feature/drop-middleware branch 2 times, most recently from c5ab993 to 5399cda Compare June 3, 2022 14:27
@Xerkus Xerkus force-pushed the feature/drop-middleware branch from 5399cda to 5be83e9 Compare June 3, 2022 14:29
@Xerkus
Copy link
Member Author

Xerkus commented Jun 3, 2022

@weierophinney I restored documentation page about laminas-mvc-middleware that got removed during rebase.

I think it is premature to provide migration documentation however. There are numerous changes that would need to be done to get ready for 4.0.0 which would obsolete the migration guide.
I will open a separate issue about providing migration guide in 3.x

@Xerkus
Copy link
Member Author

Xerkus commented Jun 3, 2022

Issue for migration guide to laminas-mvc-middleware is #120

weierophinney
weierophinney approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is now an issue to track the middleware changes for migration, I'm 👍

@Xerkus Xerkus linked an issue Jun 3, 2022 that may be closed by this pull request
Package http-interop/http-middleware is abandoned #1
Closed
2 tasks
@Xerkus Xerkus merged commit 9812368 into laminas:4.0.x Jun 3, 2022
@Xerkus Xerkus deleted the feature/drop-middleware branch June 3, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weierophinney weierophinney weierophinney approved these changes

Assignees
No one assigned
Labels
BC Break Feature Removal
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Package http-interop/http-middleware is abandoned
2 participants
@Xerkus @weierophinney