Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improve from_source docstrings for entities #179

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bionty/_shared_docstrings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
doc_from_source = """\
source: Optional Source record to use
mute: Whether to suppress logging
"""
14 changes: 14 additions & 0 deletions bionty/base/dev/_doc_util.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from textwrap import dedent


def _doc_params(**kwds): # pragma: no cover
r"""\
Docstrings should start with "\" in the first line for proper formatting.
"""

def dec(obj):
obj.__orig_doc__ = obj.__doc__
obj.__doc__ = dedent(obj.__doc__).format_map(kwds)
return obj

return dec
4 changes: 1 addition & 3 deletions bionty/base/dev/_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
from bionty.base._settings import settings


def load_yaml(
filename: Union[str, Path], convert_dates: bool = True
): # pragma: no cover
def load_yaml(filename: Union[str, Path]): # pragma: no cover
with open(filename) as f:
return yaml.safe_load(f)

Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_bfxpipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params
from bionty.base.dev._io import s3_bionty_assets

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_biosample.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_cellline.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_cellmarker.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_celltype.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_developmentalstage.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_disease.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_drug.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_ethnicity.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_experimentalfactor.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@

from bionty.base._ontology import Ontology
from bionty.base._public_ontology import PublicOntology
from bionty.base.entities._shared_docstrings import _doc_params, organism_removed
from bionty.base.dev._doc_util import _doc_params
from bionty.base.entities._shared_docstrings import organism_removed


@_doc_params(doc_entities=organism_removed)
Expand Down
5 changes: 3 additions & 2 deletions bionty/base/entities/_gene.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
from __future__ import annotations

from typing import TYPE_CHECKING, Literal, NamedTuple
from typing import TYPE_CHECKING, Literal, NamedTuple, overload

import pandas as pd
from lamin_utils import logger

from bionty.base._public_ontology import PublicOntology
from bionty.base._settings import settings
from bionty.base.dev._doc_util import _doc_params
from bionty.base.dev._io import s3_bionty_assets

from ._organism import Organism
from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites

if TYPE_CHECKING:
from collections.abc import Iterable
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_organism.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
import pandas as pd

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params
from bionty.base.dev._io import s3_bionty_assets
from bionty.base.entities._shared_docstrings import _doc_params, organism_removed
from bionty.base.entities._shared_docstrings import organism_removed


@_doc_params(doc_entities=organism_removed)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_pathway.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_phenotype.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
3 changes: 2 additions & 1 deletion bionty/base/entities/_protein.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
16 changes: 0 additions & 16 deletions bionty/base/entities/_shared_docstrings.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
from textwrap import dedent


def _doc_params(**kwds): # pragma: no cover
r"""\
Docstrings should start with "\" in the first line for proper formatting.
"""

def dec(obj):
obj.__orig_doc__ = obj.__doc__
obj.__doc__ = dedent(obj.__doc__).format_map(kwds)
return obj

return dec


doc_entites = """\
organism: `name` of `Organism` entity.
source: The key of the source in the local.yml versions file.
Expand Down
5 changes: 3 additions & 2 deletions bionty/base/entities/_tissue.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from __future__ import annotations

from typing import Literal, Optional
from typing import Literal

from bionty.base._public_ontology import PublicOntology
from bionty.base.dev._doc_util import _doc_params

from ._shared_docstrings import _doc_params, doc_entites
from ._shared_docstrings import doc_entites


@_doc_params(doc_entities=doc_entites)
Expand Down
Loading
Loading