feat: allow replacement of entire datafile when the schema lines up correctly #3408
+716
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebbyChefNEQ
changed the title
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
3 times, most recently
from
f636176 to
7881bf7
Compare
chebbyChefNEQ
commented
Jan 30, 2025
| @@ -23,21 +23,25 @@ | |||
| //! them to be compatible. | |||
| //! | |||
| //! | | Append | Delete / Update | Overwrite/Create | Create Index | Rewrite | Merge | Project | UpdateConfig | | |||
There was a problem hiding this comment.
changed (1), (2), (3) to emoji so the table width align better
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
6 times, most recently
from
c1845b6 to
c615eb0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3408 +/- ##
==========================================
- Coverage 78.86% 78.77% -0.10%
==========================================
Files 250 250
Lines 91602 91711 +109
Branches 91602 91711 +109
==========================================
Hits 72244 72244
- Misses 16395 16503 +108
- Partials 2963 2964 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
3 times, most recently
from
a532430 to
4d50cac
Compare
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
2 times, most recently
from
6feccd3 to
895d8d0
Compare
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
3 times, most recently
from
7f65391 to
d757a62
Compare
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
from
d757a62 to
bea9bd0
Compare
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
3 times, most recently
from
63e6794 to
b300e35
Compare
chebbyChefNEQ
force-pushed
the
rmeng/null-col
branch
from
b300e35 to
990c612
Compare
chebbyChefNEQ
commented
Feb 3, 2025
| @@ -134,7 +134,7 @@ def take_rows( | |||
| if indices[i] > indices[i + 1]: | |||
| raise ValueError( | |||
| f"Indices must be sorted in ascending order for \ | |||
| file API, got {indices[i]} > {indices[i+1]}" | |||
| file API, got {indices[i]} > {indices[i + 1]}" | |||
chebbyChefNEQ
commented
Feb 3, 2025
| @@ -161,7 +161,7 @@ def on_write_complete( | |||
|
|
|||
| if len(write_results) == 0: | |||
| warnings.warn( | |||
| "write results is empty. please check ray version " "or internal error", | |||
| "write results is empty. please check ray version or internal error", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internal design doc see notion or ping me
What this PR implements
Plan of attack:
TODO: