Add DocQA Tool #330
Merged
Add DocQA Tool #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camiloaz
approved these changes
Dec 19, 2024
| 'label': table', | ||
| 'order': 1119, | ||
| 'caption': [{'Column 1': 'Value 1', 'Column 2': 'Value 2'}, | ||
| 'summary': 'This table illustrates a trend of ...'}, | ||
| ], | ||
| ",document_extraction | ||
| "'document_qa' is a tool that can answer any questions about arbitrary documents, presentations, or tables. It's very useful for document QA tasks, you can ask it a specific question or ask it to return a JSON object answering multiple questions about the document.","document_qa(prompt: str, image: numpy.ndarray) -> str: |
There was a problem hiding this comment.
would it be better to not use "QA" and instead use "question answering"? i know that changing this would require new benchmarking runs, so no need to address it right now, but maybe for the future.
There was a problem hiding this comment.
Like call the tool document_question_answering instead of document_qa? I think in this case it's fine, it seems to understand QA pretty well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple things: