Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Updates #455

Merged
merged 2 commits into from
Jan 22, 2025
Merged

CI Updates #455

merged 2 commits into from
Jan 22, 2025

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Jan 21, 2025

PR Summary

  • migrate changes from spiner/ports-of-call
  • add new versions (replaces update spackage #431)
  • update build_and_test.sh with various improvements

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@rbberger rbberger requested a review from Yurlungur January 21, 2025 22:35
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when ready

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think there might be a logic error unless I'm misunderstanding things.

.gitlab/build_and_test.sh Show resolved Hide resolved
spack-repo/packages/spiner/package.py Show resolved Hide resolved
@rbberger rbberger merged commit e3799f3 into main Jan 22, 2025
8 checks passed
@rbberger rbberger deleted the rberger/ci_updates branch January 22, 2025 05:29
@jhp-lanl
Copy link
Collaborator

Thanks for the answers to my questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants