Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update settings #108

Merged
merged 2 commits into from
Dec 19, 2024
Merged

ci: update settings #108

merged 2 commits into from
Dec 19, 2024

Conversation

rbberger
Copy link
Collaborator

PR Summary

Updates some CI settings

PR Checklist

  • Code is formatted. (You can use the format_spiner make target.)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • If preparing for a new release, update the version in cmake.

Yurlungur
Yurlungur approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the catch2 version also needs to be bumped to support building on newer OS VMs on github.

@rbberger
Copy link
Collaborator Author

Please hold off on merging these. Looks like we might have a better location for these build folders.

@rbberger rbberger merged commit ac0669a into main Dec 19, 2024
4 checks passed
@rbberger rbberger deleted the rberger/ci_updates branch December 19, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbberger @Yurlungur