Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Refine error messages for detecting lost connections (Debian bookworm compatibility) #54111

Open
wants to merge 1 commit into
base: 11.x
Choose a base branch
from

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Jan 8, 2025

Summary

Same as #53794 , which was for L10, but this time for L11 (I thought there was some kind of L10 -> L11 merge, but alas, there isn't)

Paraphrasing from the other PR:

Last year I added those two via #47398 Please see details and reasoning there, it still applies; TL;DR:

Ever since I moved from AWS Aurora to using AWS RDS Proxy, which
(similar to pgbouncer) is essential to not overload the primary database
with connection, I sporadically see these messages. This affects
scheduled tasks, worker, HTTP requests; it's across the whole board.

What I didn't knew back then was that the order/format of those messages very much dependent on the underlying libraries (libpq and or libssl presumably) and once we started to upgrade from Debian bullseye to bookworm, they changed and now are randomly interrupting our service again.

The new (complete) messages look like this:

SQLSTATE[08006] [7] connection to server at "…" (…), port 5… failed: SSL error: sslv3 alert unexpected message (Connection: main, SQL: …

That is, it still contains "SSL error: sslv3 alert unexpected message" but there's now connection specific information after the SQLSTATE prefix.

Since lost connection detection is based on exact string matching and not regex, we're just removing the magic numbers in front and still keep backwards compatibility.

Notes

Please accept this this PR against Laravel 10.x because we're still using and it requires the fix there (we're in the progress moving to L11, but it still takes time).

Thanks!

…ookworm compatibility)

Same as laravel#53794 , which was for
L10, but this time for L11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant