removing strict and quiet from tidy_add_variable_labels()

R/tidy_add_term_labels.R

@@ -76,7 +76,7 @@ tidy_add_term_labels <- function(x,
   }
 
   if (!"var_label" %in% names(x)) {
-    x <- x |> tidy_add_variable_labels(model = model, quiet = quiet)
+    x <- x |> tidy_add_variable_labels(model = model)
   }
   if (!"contrasts" %in% names(x)) {
     x <- x |> tidy_add_contrasts(model = model)

R/tidy_add_variable_labels.R

@@ -16,8 +16,6 @@
 #' A tidy tibble as produced by `tidy_*()` functions.
 #' @param labels ([`formula-list-selector`][gtsummary::syntax])\cr
 #' An optional named list or a named vector of custom variable labels.
-#' @param interaction_sep (`string`)\cr
-#' Separator for interaction terms.
 #' @param model (a model object, e.g. `glm`)\cr
 #' The corresponding model, if not attached to `x`.
 #' @inheritParams tidy_plus_plus
@@ -36,17 +34,15 @@
 #'   tidy_and_attach() |>
 #'   tidy_add_variable_labels(
 #'     labels = list(
-#'       "(Intercept)" = "Custom intercept",
-#'       Sex = "Gender",
-#'       "Class:Age" = "Custom label"
+#'       "(Intercept)" ~ "Custom intercept",
+#'       Sex ~ "Gender",
+#'       "Class:Age" ~ "Custom label"
 #'     )
 #'   )
 tidy_add_variable_labels <- function(x,
                                      labels = NULL,
                                      interaction_sep = " * ",
-                                     model = tidy_get_model(x),
-                                     quiet = FALSE,
-                                     strict = FALSE) {
+                                     model = tidy_get_model(x)) {
   if (is.null(model)) {
     cli::cli_abort(c(
       "{.arg model} is not provided.",
@@ -95,16 +91,6 @@ tidy_add_variable_labels <- function(x,
   var_labels <- var_labels |>
     .update_vector(additional_labels)
 
-  # check if all elements of labels are in x
-  # show a message otherwise
-  not_found <- setdiff(names(labels), names(var_labels))
-  if (length(not_found) > 0 && !quiet) {
-    cli_alert_danger("{.code {not_found}} terms have not been found in {.code x}.")
-  }
-  if (length(not_found) > 0 && strict) {
-    cli::cli_abort("Incorrect call with `labels=`. Quitting execution.", call = NULL)
-  }
-
   var_labels <- var_labels |>
     .update_vector(labels)
 

R/tidy_plus_plus.R

@@ -222,8 +222,7 @@ tidy_plus_plus <- function(model,
   res <- res |>
     tidy_add_variable_labels(
       labels = variable_labels,
-      interaction_sep = interaction_sep,
-      quiet = quiet
+      interaction_sep = interaction_sep
     ) |>
     tidy_add_term_labels(
       labels = term_labels,
@@ -236,7 +235,8 @@ tidy_plus_plus <- function(model,
     res <- res |>
       tidy_add_header_rows(
         show_single_row = {{ show_single_row }},
-        strict = strict, quiet = quiet
+        strict = strict,
+        quiet = quiet
       )
   }
 

tests/testthat/test-add_variable_labels.R

@@ -51,32 +51,6 @@ test_that("tidy_add_variable_labels() works for basic models", {
     )
   )
 
-  # no error if providing labels not corresponding to an existing variable
-  # but display a message
-  expect_error(
-    mod |>
-      tidy_and_attach() |>
-      tidy_add_variable_labels(
-        labels = list(aaa = "aaa", bbb = "bbb", ccc = 44)
-      ),
-    NA
-  )
-  expect_message(
-    mod |>
-      tidy_and_attach() |>
-      tidy_add_variable_labels(
-        labels = list(aaa = "aaa", bbb = "bbb", ccc = 44)
-      )
-  )
-  expect_error(
-    mod |>
-      tidy_and_attach() |>
-      tidy_add_variable_labels(
-        labels = list(aaa = "aaa", bbb = "bbb", ccc = 44),
-        strict = TRUE
-      )
-  )
-
   # model with only an interaction term
   mod <- lm(age ~ factor(response):marker, gtsummary::trial)
   res <- mod |>