Merge pull request #84 from larmarange/tt3

improve tests
larmarange · Jan 7, 2025 · f7d8b98 · f7d8b98
2 parents 629a438 + 700f422
commit f7d8b98
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 96 deletions.
diff --git a/tests/testthat.R b/tests/testthat.R
@@ -3,8 +3,8 @@
 #
 # Where should you do additional test configuration?
 # Learn more about the roles of various files in:
-# * https://r-pkgs.org/tests.html
-# * https://testthat.r-lib.org/reference/test_package.html#special-files
+# * https://r-pkgs.org/testing-design.html#sec-tests-files-overview
+# * https://testthat.r-lib.org/articles/special-files.html
 
 library(testthat)
 library(ggstats)

diff --git a/tests/testthat/_snaps/stat_prop/geom-prop-bar-geom-prop-text.svg b/tests/testthat/_snaps/stat_prop/geom-prop-bar-geom-prop-text.svg
diff --git a/tests/testthat/test-ggcoef_model.R b/tests/testthat/test-ggcoef_model.R
@@ -200,9 +200,8 @@ test_that("ggcoef_compare()", {
     c("Male", "Female", "Child", "Adult", "1st", "2nd", "3rd", "Crew")
   )
 
-  expect_error(
-    ggcoef_compare(models, add_reference_rows = FALSE),
-    NA
+  expect_no_error(
+    ggcoef_compare(models, add_reference_rows = FALSE)
   )
 })
 
@@ -305,23 +304,20 @@ test_that("ggcoef_model() works with pairwise contratst", {
   skip_if_not_installed("broom.helpers")
   skip_if_not_installed("emmeans")
   mod <- lm(Sepal.Length ~ Sepal.Width + Species, data = iris)
-  expect_error(
-    ggcoef_model(mod, add_pairwise_contrasts = TRUE),
-    NA
+  expect_no_error(
+    ggcoef_model(mod, add_pairwise_contrasts = TRUE)
   )
-  expect_error(
+  expect_no_error(
     ggcoef_model(
       mod,
       add_pairwise_contrasts = TRUE,
       pairwise_variables = dplyr::starts_with("Sp"),
       keep_model_terms = TRUE
-    ),
-    NA
+    )
   )
   mod2 <- lm(Sepal.Length ~ Species, data = iris)
-  expect_error(
-    ggcoef_compare(list(mod, mod2), add_pairwise_contrasts = TRUE),
-    NA
+  expect_no_error(
+    ggcoef_compare(list(mod, mod2), add_pairwise_contrasts = TRUE)
   )
 })
 

diff --git a/tests/testthat/test-gglikert.R b/tests/testthat/test-gglikert.R
@@ -56,9 +56,8 @@ test_that("gglikert()", {
     gglikert(df)
   )
 
-  expect_error(
-    d <- gglikert_data(df),
-    NA
+  expect_no_error(
+    d <- gglikert_data(df)
   )
   expect_equal(levels(d$.answer), likert_levels)