Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #166

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Improve error messages #166

merged 6 commits into from
Jan 6, 2025

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jan 2, 2025

Also added favicons and upgraded to testthat 3rd edition.

This doesn't add any Imports to the package since dplyr imports cli already.

had to modify the lintr config due to r-lib/lintr#2252, r-lib/lintr#2416

@larmarange
Copy link
Owner

Thank you for your PR.

I will merge it next week before submitting a new release of labelled

@larmarange larmarange merged commit c7b1111 into larmarange:main Jan 6, 2025
10 checks passed
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (9d0533c) to head (3acff69).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/remove_labels.R 70.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   93.42%   93.45%   +0.03%     
==========================================
  Files          18       18              
  Lines        1308     1284      -24     
==========================================
- Hits         1222     1200      -22     
+ Misses         86       84       -2     
Files with missing lines Coverage Δ
R/copy_labels.R 100.00% <100.00%> (ø)
R/na_values.R 94.33% <100.00%> (-0.11%) ⬇️
R/to_labelled.R 95.78% <100.00%> (+3.78%) ⬆️
R/val_labels.R 93.45% <100.00%> (-0.32%) ⬇️
R/var_label.R 99.04% <100.00%> (-0.06%) ⬇️
R/remove_labels.R 90.24% <70.00%> (-2.26%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants