Make all server unlisten when then they finish.

larsbrinkhoff · Jan 29, 2025 · afa6e48 · afa6e48
1 parent 67e2c1a
commit afa6e48
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 4 deletions.
diff --git a/apps/discard.c b/apps/discard.c
@@ -25,9 +25,14 @@ static void discard_server (int sock)
     if (ncp_read (connection, buffer, &size) == -1)
       fprintf (stderr, "NCP read error.\n");
     if (size <= 0)
-      return;
+      break;
     fprintf (stderr, "Read %d octets.\n", size);
   }
+
+  if (ncp_unlisten (sock) == -1) {
+    fprintf (stderr, "NCP unlisten error.\n");
+    exit (1);
+  }
 }
 
 static void usage (const char *argv0)

diff --git a/apps/echo.c b/apps/echo.c
@@ -79,15 +79,21 @@ static void echo_server (int sock)
     if (ncp_read (connection, buffer, &size) == -1)
       fprintf (stderr, "NCP read error.\n");
     if (size <= 0)
-      return;
+      goto end;
     for (ptr = buffer; size > 0; ptr += n, size -= n) {
       n = size;
       if (ncp_write (connection, ptr, &n) == -1)
         fprintf (stderr, "NCP read error.\n");
       if (n <= 0)
-        return;
+        goto end;
     }
   }
+
+ end:
+  if (ncp_unlisten (sock) == -1) {
+    fprintf (stderr, "NCP unlisten error.\n");
+    exit (1);
+  }
 }
 
 static void usage (const char *argv0)

diff --git a/apps/finser.c b/apps/finser.c
@@ -5,6 +5,8 @@
 #include <string.h>
 #include "ncp.h"
 
+#define SOCKET  0117
+
 int main (int argc, char **argv)
 {
   char command[1000];
@@ -26,7 +28,7 @@ int main (int argc, char **argv)
   }
 
   size = 8;
-  if (ncp_listen (0117, &size, &host, &connection) == -1) {
+  if (ncp_listen (SOCKET, &size, &host, &connection) == -1) {
     fprintf (stderr, "NCP listen error.\n");
     exit (1);
   }
@@ -52,4 +54,10 @@ int main (int argc, char **argv)
     exit (1);
   }
 
+  if (ncp_unlisten (SOCKET) == -1) {
+    fprintf (stderr, "NCP unlisten error.\n");
+    exit (1);
+  }
+
+  return 0;
 }
diff --git a/apps/gateway.c b/apps/gateway.c
@@ -187,6 +187,11 @@ static void ncp_to_tcp (int sock, const char *host, const char *port)
     fprintf (stderr, "NCP close error.\n");
     exit (1);
   }
+
+  if (ncp_unlisten (sock) == -1) {
+    fprintf (stderr, "NCP unlisten error.\n");
+    exit (1);
+  }
 }
 
 static void usage (const char *argv0)

diff --git a/apps/telnet.c b/apps/telnet.c
@@ -460,6 +460,11 @@ static void telnet_server (int host, int sock,
     fprintf (stderr, "NCP close error.\n");
     exit (1);
   }
+
+  if (ncp_unlisten (sock) == -1) {
+    fprintf (stderr, "NCP unlisten error.\n");
+    exit (1);
+  }
 }
 
 static void usage (const char *argv0, int code)