Skip to content

Commit

Permalink
[aic-py] lint, pyright, formatting settings
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanlastmileai committed Nov 22, 2023
1 parent 2faf963 commit 7ba6181
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 17 deletions.
1 change: 1 addition & 0 deletions .lint_glob_excludes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
python/build/**
5 changes: 3 additions & 2 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"meta.sapling-scm",
"ms-python.python",
"ms-python.vscode-pylance",
"ms-python.pylint",
"ms-toolsai.jupyter"
"ms-python.pylint",
"ms-toolsai.jupyter",
"ms-python.isort"
]
}
8 changes: 5 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
"[python]": {
"editor.defaultFormatter": "ms-python.black-formatter",
"editor.formatOnSave": true,
"python.formatting.provider": "none",
"python.formatting.blackArgs": ["--line-length", "99"]
}
"editor.rulers": [88]
},
"black-formatter.args": ["--line-length=88"],
// example: "--disable=C0114,C0115,C0116"
"pylint.args": []
}
24 changes: 12 additions & 12 deletions pyrightconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// {
// "typeCheckingMode": "strict",
// "include": ["python"],
// "exclude": ["python/build"],
// "ignore": [],
// "venv": "aiconfig",
// "pythonVersion": "3.11",
// "reportUnknownMemberType": false,
// "reportUnknownVariableType": false,
// "reportUnknownArgumentType": false,
// "reportMissingTypeStubs": false
// }
{
"typeCheckingMode": "strict",
"include": ["python"],
"exclude": ["python/build"],
"ignore": [],
"venv": "aiconfig",
"pythonVersion": "3.10",
"reportUnknownMemberType": false,
"reportUnknownVariableType": false,
"reportUnknownArgumentType": false,
"reportMissingTypeStubs": false
}

0 comments on commit 7ba6181

Please sign in to comment.