[bug fix][AIC-py] sort of do exception handling during streaming #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanlastmileai
force-pushed
the
pr860
branch
from
aef38d3 to
9ff6522
Compare
saqadri
reviewed
Jan 10, 2024
jonathanlastmileai
changed the title
jonathanlastmileai
force-pushed
the
pr860
branch
2 times, most recently
from
20bf3a4 to
5649184
Compare
jonathanlastmileai
requested review from
rholinshead,
suyoglastmileai,
Ankush-lastmile and
rossdanlm
as code owners
saqadri
approved these changes
Jan 10, 2024
jonathanlastmileai
force-pushed
the
pr860
branch
from
5649184 to
94d1709
Compare
This piggybacks on the cancellation during stream flow, which works as far as I've tested. The frontend gets the message. <img width="396" alt="image" src="https://github.com/lastmile-ai/aiconfig/assets/148090348/5e5f603f-4ac3-405e-aead-a3dbfb78d163">
jonathanlastmileai
force-pushed
the
pr860
branch
from
94d1709 to
44fbded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bug fix][AIC-py] sort of do exception handling during streaming
This piggybacks on the cancellation during stream flow, which works as far as I've tested.
The frontend gets the message.