Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firstaid for acro #1284

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Add firstaid for acro #1284

merged 1 commit into from
Feb 29, 2024

Conversation

josephwright
Copy link
Member

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Pull requests in this repository are intended for LaTeX Team members only.

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Under development
  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

@muzimuzhi
Copy link
Contributor

muzimuzhi commented Feb 29, 2024

With l3kernel 2024-02-18 (or maybe 2024-02-20), loading acro won't raise errors any more, and since acro.sty always clears \l__acro_tmpa_prop before setting to it, it seems to me there's no urgent need to firstaid acro.

PS: Original report to acro: cgnieder/acro#268.

@josephwright
Copy link
Member Author

@muzimuzhi Bruno's patch to make that work is meant to be temporary. I'm trying to cover the case where someone installs the TL'24 ISO then updates just expl3: ideally that should 'just work' even if we remove Bruno's patch (for performance reasons).

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything wrong with this and giving the timeline I would apply the firstaid.

@josephwright
Copy link
Member Author

@FrankMittelbach Good to go for all three?

@FrankMittelbach
Copy link
Member

guess so, but they probably don't play if merged one after another (without further updating) or do they?

@josephwright
Copy link
Member Author

No but I'll sort that :)

@josephwright josephwright merged commit a2b9b83 into main Feb 29, 2024
78 checks passed
@josephwright josephwright deleted the firstaid/acro branch February 29, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants