-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float placement bug #1646
Float placement bug #1646
Conversation
# Conflicts: # base/testfiles/tlb-fltrace-002.luatex.tlg # base/testfiles/tlb-fltrace-003.luatex.tlg # base/testfiles/tlb-fltrace-004.luatex.tlg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope I found all the problems!
Rollbacks not checked.
base/doc/ltnews41.tex
Outdated
When floats are placed onto the current or next page, \LaTeX{} makes | ||
several tests to find an area that can receive the float. One of these | ||
tests calculates how much space is already used on the page and how | ||
much additional space is necessary to place the float in a particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
necessary ==> needed
base/doc/ltnews41.tex
Outdated
variable and compared to thespace still available on the page. | ||
|
||
If the test fails, the algorithm tries the next area. Unfortunately, | ||
it reused the value in that internal variable as the starting point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it reused ==> it was reusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? I think 'it reused' feels OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "it had been" even!
And maybe need to expand what "it" is here?
Thus:
Unfortunately, this will result in the reuse of the value . . .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new suggestion doesn't convey what I intended to say. was reusing is fine if you want that, but I'm not going to explain "it" :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject to Chris's doc refinements
including those you do not agree with? Can you two please make up your minds? |
You expect us to agree!! ??? |
I am not totally opposed to any of them - so merge once they are all done and we can see what happens when Barbara looks at the news :) |
So I was prompted to make a few further suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with (either version) of documentation changes.
no, but one can still hope ... |
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated