Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct \changes entries #1654

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Feb 6, 2025

Introduced by 7726e85 (ltmarks & multicol (#1548), 2024-11-18).

In PR commit e82f1f0 (which was part of the merged PR #1548), two copies of flawed \changes{v1.1a}{2025/06/01}{} were added to base/ltpage.dtx. They both used date and version in the future (the ltpage.dtx was at '2024/11/16 v1.0o', and empty descriptions.

Relevant diff lines

diff --git a/base/ltpage.dtx b/base/ltpage.dtx
index f4efe0fd5..2ac5ad3db 100644
--- a/base/ltpage.dtx
+++ b/base/ltpage.dtx
@@ -33,7 +33,7 @@
 %<*driver>
 % \fi
 \ProvidesFile{ltpage.dtx}
-             [2022/04/03 v1.0n LaTeX Kernel (page style setup)]
+             [2024/11/16 v1.0o LaTeX Kernel (page style setup)]
 % \iffalse
 \documentclass{ltxdoc}
 \GetFileInfo{ltpage.dtx}
@@ -180,8 +180,8 @@
 %    \begin{macrocode}
 %</2ekernel>
 %<*2ekernel|latexrelease>
-%<latexrelease>\IncludeInRelease{2022/06/01}%
-%<latexrelease>                 {\markboth}{New mark support}%
+%<latexrelease>\IncludeInRelease{2025/06/01}%
+%<latexrelease>                 {\markboth}{Drop legacy mark support}%
 %    \end{macrocode}
 %
 %
@@ -204,61 +204,24 @@
 %                             error (pr/3203).}
 % \changes{v1.0m}{2020/07/27}{Don't make the command \cs{long} (gh/354)}
 % \changes{v1.0n}{2022/04/04}{Interface with new mark mechanism}
+% \changes{v1.1a}{2025/06/01}{}
 %    \begin{macrocode}
 \ExplSyntaxOn
 \DeclareRobustCommand*\markboth[2]{%

This PR corrects these two \changes entries. Found when digging for #1653.

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Ready to merge

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added
  • [n/a] Version and date string updated in changed source files
  • [n/a] Relevant \changes entries in source included
  • [n/a] Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated

Introduced by 7726e85 (ltmarks & multicol (latex3#1548), 2024-11-18).
@FrankMittelbach
Copy link
Member

will have to wait until firstaid correction #1655 has been applied

@FrankMittelbach FrankMittelbach merged commit 0925059 into latex3:develop Feb 6, 2025
18 of 43 checks passed
@FrankMittelbach
Copy link
Member

now it should go in cleanly, thanks for the fix

@muzimuzhi muzimuzhi deleted the changes-entries branch February 6, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants