Move luamml patches into latex-lab #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into UF-latex-lab-luamml
josephwright
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
I think a check over the line-ends would be sensible - outside of expl3 syntax, I'd prefer to see them ending with % where a space can creep in, even if used in math mode. But as this is code being moved from elsewhere, I've gone for 'approve' not 'request changes'.
required/latex-lab/math-tagging-examples/math-17-alt+mathmlAF+texAF.tlg
Outdated
Show resolved
Hide resolved
FrankMittelbach
approved these changes
Feb 20, 2025
davidcarlisle
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the various patches from luamml into the latex-lab code and replaced them with proper sockets.
The various amsmath patches already present in latex-lab moved into latex-lab-amsmath.
A number of bugs have been fixed in the process, and with luatex more luatex primitives are used (e.g. \mathstyle in \mathpalette).
The split environment isn't properly tagged yet, but a (partly) fix is comming.
The default pdfversion has been set to 2.0 with \DocumentMetadata.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated