-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh1667 #1668
Gh1667 #1668
Conversation
I think something got confused here. You have deleted the plug (wrongly) named I think the correct thing to do would be to simply change the name of the plug |
The plug
That is not true either (I think). Footmisc implements it the way I corrected it, because the implementation in latex-lab was simply wrong before (and that is also how it is documented e.g., TLC3 page I-215).
So I think everything is correct. |
ok looks like I have to many versions open ... guess you are right here, there is a mistake on my part, so forget the first part of my reply. |
|
you were right here too ... not my day ... |
Well, maybe today is really not your day ;-). Now the descriptions in clsguide and ltnews are correct, but the actual plug definition (starting on line 2468) still uses the wrong name % \begin{plugdecl}{floats-footnotes-space}
% As before but the \cs{vfill} is at the bottom (page is ragged
% bottom).
% \begin{macrocode}
\NewSocketPlug {build/column/outputbox}{floats-footnotes-space} {%
\@outputbox@attachfloats
\@if@footnotes@TF
{\@outputbox@append{\vfill}}%
{\@outputbox@reinsertbskip}%
\@outputbox@appendfootnotes
}
% \end{macrocode}
% \end{plugdecl} The changes entry could also be reworded: 2025-02-19 Frank Mittelbach <[email protected]>
* ltoutput.dtx:
Dropped plug floats-footnoteotes-space that was added by mistake No plug was dropped, and the wrong name was not so badly wrong that it contained the word |
# Conflicts: # base/changes.txt # required/latex-lab/changes.txt
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updatedadditional plugs as suggested aren't yet included (probably after next -dev release)