Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh1667 #1668

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Gh1667 #1668

merged 10 commits into from
Feb 20, 2025

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated

additional plugs as suggested aren't yet included (probably after next -dev release)

@user227621
Copy link
Contributor

I think something got confused here. You have deleted the plug (wrongly) named floats-footnotes-space (which actually implements the sequence floats-space-footnotes). This means that there is no longer a plug that implements the sequence floats-space-footnotes. The sequence for the bottom option has been changed to space-floats-footnotes, but that should actually be floats-space-footnotes.

I think the correct thing to do would be to simply change the name of the plug floats-footnotes-space to floats-space-footnotes and correct its description.

@FrankMittelbach
Copy link
Member Author

FrankMittelbach commented Feb 20, 2025

I think something got confused here. You have deleted the plug (wrongly) named floats-footnotes-space (which actually implements the sequence floats-space-footnotes). This means that there is no longer a plug that implements the sequence floats-space-footnotes.

The plug floats-space-footnotes was already in the file (with the correct implementation). The other one (now deleted) was simply a copy with a different name.

The sequence for the bottom option has been changed to space-floats-footnotes, but that should actually be floats-space-footnotes.

That is not true either (I think).

Footmisc implements it the way I corrected it, because the implementation in latex-lab was simply wrong before (and that is also how it is documented e.g., TLC3 page I-215).
Check out

\documentclass{article}

%\usepackage[bottom]{footmisc}                  % floats-space-footnote
%\usepackage[bottomfloats]{footmisc}            % footnotes-space-floats
\usepackage[bottomfloats,belowfloats]{footmisc} % space-floats-footnotes

\raggedbottom

\usepackage{kantlipsum}

\begin{document}

\begin{figure}[t] FIGURE \caption{A}\end{figure}

\kant*[1]\footnote{A footnote}

\begin{figure}[b] FIGURE \caption{B}\end{figure}

\kant*[2]\footnote{A footnote}

\pagebreak

\kant[3-6]\kant*[7]\footnote{A footnote}

This shows the clearpage skip bug without footmisc!

\begin{figure}[b] FIGURE \caption{C}\end{figure}

\end{document}

So I think everything is correct.

@FrankMittelbach
Copy link
Member Author

I think something got confused here. You have deleted the plug (wrongly) named floats-footnotes-space (which actually implements the sequence floats-space-footnotes). This means that there is no longer a plug that implements the sequence floats-space-footnotes.

The plug floats-space-footnotes was already in the file (with the correct implementation). The other one (now deleted) was simply a copy with a different name.

ok looks like I have to many versions open ... guess you are right here, there is a mistake on my part, so forget the first part of my reply.

@u-fischer
Copy link
Member

  • \usepackage[bottom]{footmisc} should use the (missing) floats-space-footnotes. That is what I get without the new or.

  • The date of the footmisc replacement should be updated, currently it says

latex-lab-footmisc 2022/03/08 v6.0d a miscellany of footnote facilitie
s -- latex-lab version
  • Typo in ltoutput: defaultfor

@FrankMittelbach
Copy link
Member Author

The sequence for the bottom option has been changed to space-floats-footnotes, but that should actually be floats-space-footnotes.

That is not true either (I think).

you were right here too ... not my day ...

@user227621
Copy link
Contributor

you were right here too ... not my day ...

Well, maybe today is really not your day ;-). Now the descriptions in clsguide and ltnews are correct, but the actual plug definition (starting on line 2468) still uses the wrong name floats-footnotes-space (instead of floats-space-footnotes) and has the wrong description:

%  \begin{plugdecl}{floats-footnotes-space}
%     As before but the \cs{vfill} is at the bottom (page is ragged
%    bottom).
%    \begin{macrocode}
\NewSocketPlug {build/column/outputbox}{floats-footnotes-space} {%
  \@outputbox@attachfloats
  \@if@footnotes@TF
      {\@outputbox@append{\vfill}}%
      {\@outputbox@reinsertbskip}%
  \@outputbox@appendfootnotes
}
%    \end{macrocode}
%  \end{plugdecl}

The changes entry could also be reworded:

2025-02-19  Frank Mittelbach  <[email protected]>

	* ltoutput.dtx:
	Dropped plug floats-footnoteotes-space that was added by mistake

No plug was dropped, and the wrong name was not so badly wrong that it contained the word footnoteotes ;-).

# Conflicts:
#	base/changes.txt
#	required/latex-lab/changes.txt
@FrankMittelbach FrankMittelbach merged commit 994b711 into develop Feb 20, 2025
86 checks passed
@FrankMittelbach FrankMittelbach deleted the gh1667 branch February 20, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants