Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Post-release (0.2.0) dependency updates & related (getodk#163)
* Bump Node version matrix Manually verified on 22.4.1 (in case `tree-sitter` et al have issues): - clean install - monorepo-wide build and test * Bump Yarn to v1 latest Manually verified again (in case `tree-sitter` et al have issues): - clean install - monorepo-wide build and test * Dependency updates Includes (automated via codemod) update to `turbo.json`, which was necessary to validate build & test. Note that this was a semver major update. Seems to have gone smoothly (after rolling back the dep update and re-updating with the codemod). The release notes hype an improved CLI experience, but I don’t think we’ll benefit from it unless/until we embrace Turborepo more fully (i.e. moving more of the task orchestration from package scripts into turbo.json). - - - After install in dev environments, you’ll likely need to run `yarn playwright install` to update the browsers used by Playwright (both directly, and in VItest browser mode) - - - For the most part, this is just latest of everything that has updates, except: - Vue, which we have currently pinned to the version in central-frontend. That should really be updated: IIRC it hadn’t been for 10mo when we last did updates, and it’s now one of our two most error-prone/manual intervention driving deps. If not careful, lockfile-only updates can cause build failures in `@getodk/web-forms`! - Primevue, which I expect we’ll want to update separately with dedicated effort to address its semver-major changes. - Sass, which only has a patch release, but it introduces some [deprecation warnings](https://sass-lang.com/documentation/breaking-changes/mixed-decls/). We should definitely heed these warnings! But as far as I could tell, they’re out of our control (all coming from Primevue styles). We’ll likely want to update Sass and Primevue together when ready. - To further reduce error-prone/manual intervention of the other (tree-sitter &co), more of its *implied peer dependencies* have been pinned to exact versions (or done so consistently across root/sub-packages). This includes `nan` and `node-gyp`. Hopefully this will reduce the risk of weird succeed-then-fail installs as I’ve seen in previous passes on this set of updates. - - - One dependency was removed from xforms-engine which was missed when we broke out the ui-solid package. - - - The most significant semver major update I saw was Vitest &co. From reading their release notes, this doesn’t seem like a risky update. There will be some adjustments in a a later commit. - - - Not everything follows semver! We continue to pin `typescript` with ~ (accounting for the fact that TS x.y updates are typically where breaking changes are introduced). * Fix: Adapt Node runtime detection to account for Vitest browser mode changes * Vitest config updates… 1. In browser mode, Vitest now captures screenshots of failing tests by default. First of all, this is not useful for us, for the vast majority of our browser testing scenarios (if any!). Second of all, it apparently does this even for **expected failures**! We override this default across all packages. 2. In addressing (1), it became clear that some of the Vitest config types are not available (if importing `defineConfig` from 'vite') or cause conflicts with plugins (if importing `defineConfig` from 'vitest/config’). As a stopgap to unblock this set of dependency updates, a shared type for the `test` field is introduced, and `satisfies VitestTestConfig` is used to allow the TS language server to infer the config’s types. This was helpful for discovering the `screenshotFailures` option, as well as prompting the next change… 3. For the most part, we’ve removed `transformMode` configs as Vite-/Vitest-related tooling stabilized earlier in Web Forms exploratory development. The cases where the config remained were no longer consistent with the updated Vitest config types. I first updated them to match the new types, but then I discovered that the options are no longer necessary in any cases that remained. So they’ve been removed completely. * Format update Thanks Prettier 🙃 * Add no-op `test` script to `scripts` package This package was originally going to be removed on this branch. It had never been used, and its presence made it a much bigger hassle to validate dependency updates and other project-wide changes. Despite mentioning plans to remove the package a couple days ago, removing it now will be in conflict with getodk#162. In the interest of unblocking many substantial improvements downstream, some of which have been in limbo for a couple weeks, I’ve reverted the removal. Instead, adding this script provides a small quality of life improvement for future project-wide improvements by eliminating impediments to running all tests across all packages that actually have tests (`yarn workspaces run test` fails unless every workspace has a `test` script).
- Loading branch information
1 parent
19b31f5
commit 8348215