-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mrhs misc #1515
Merged
Merged
Feature/mrhs misc #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation overheads when memory pool is disabled
This reverts commit 8f72560.
…imization can optimize out infinities rendering the use of heterogenous atomics with an inifinity sentinal. As an alternative we can use negative zero as the sentinal. Default remains infinity, disable with QUDA_HETEROGENEOUS_ATOMIC_INF_INIT=OFF
…nvc++ allowing for the removal of the WARs deployed previously
…PrintMatrix routine. Apply same patch to genericPrintVector for future proofing
hummingtree
reviewed
Nov 27, 2024
weinbe2
reviewed
Dec 4, 2024
weinbe2
reviewed
Dec 4, 2024
weinbe2
reviewed
Dec 4, 2024
weinbe2
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending a few cosmetic requests this looks good. Thanks @maddyscientist !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit of a catch all
QUDA_MAX_MULTI_RHS_TILE
, with the default left at size 1 for now.FieldTmp
now supports creating temporaries using parameters as opposed another field instanceQUDA_HETEROGENEOUS_ATOMIC_INF_INIT=OFF
). Not a problem by default, but is with latest clang with-Ofast
.printGenericMatrix