Android: Fixes #10152: Fix broken plugin API: editor.execCommand #10153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and adds tests for the Joplin
'editor.execCommand'
command. This fixes two issues related to the command:editor.execCommand
was incorrectly extracted from the arguments list.this
was incorrect for legacy CM5 commands executed witheditor.execCommand
.Fixes #10153.
Notes
This does not completely fix the "scroll to heading" logic in the outline plugin -- it uses a legacy CM5 API to scroll to the line containing a header that isn't supported on mobile (because of how we handle scroll to work around this bug). It does, however, allow similar commands to run.
Testing
chrome://inspect
).This has been tested successfully on Android 12.