Chore: Plugin repo CLI: Only match packages with the joplin-plugin keyword #11599
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const searchResults = (await execCommand('npm search joplin-plugin --searchlimit 5000 --json', { showStdout: false, showStderr: false })).trim(); | ||
| const searchResults = (await execCommand('npm search keywords:joplin-plugin --searchlimit 5000 --json', { showStdout: false, showStderr: false })).trim(); |
There was a problem hiding this comment.
Follow-up PR: Consider using the API instead (or find some package that uses the API). Alternatively, look into sorting by last updated from the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the plugin repo CLI identifies Joplin plugins using
npm search joplin-plugin --searchlimit 5000 --json. The maximumsearchlimit, however seems to be 250 (perhaps as a result of the API).The search results returned by
npm search joplin-plugin ...currently include packages that are not Joplin plugins (e.g.clean-webpack-plugin). As such, limiting the search query to exclude packages that aren't tagged withjoplin-pluginshould allow more plugins to be identified.This pull request may fix this issue reported on the forum.
Testing
I've verified that running
npm search keywords:joplin-plugin --searchlimit 5000 --jsonfrom the command line returns search results containingjoplin-plugin.