feat: Reputation: CNS-1004 - QoS excellence epoch score aggregation #1612
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…putation-qos-score-aggregation
…putation-qos-score-aggregation
…5-reputation-pairing-score
…putation-qos-score-aggregation
…5-reputation-pairing-score
…5-reputation-pairing-score
…putation-qos-score-aggregation
…5-reputation-pairing-score
…putation-qos-score-aggregation
…5-reputation-pairing-score
…not only on epoch start
…5-reputation-pairing-score
| } | ||
| effectiveStake := sdk.NewCoin(stakeEntry.Stake.Denom, stakeEntry.TotalStake()) | ||
|
|
||
| // note the current weight used is by relay num. In the future, it might change |
There was a problem hiding this comment.
can you explain why this is? afaik this is just an incrementing number to count sessions (?)
There was a problem hiding this comment.
The goal was to give more weight to relay payments with lots of relays. I also remember is the counter, will fix later
There was a problem hiding this comment.
done. see 600464d
…putation-qos-score-aggregation
…5-reputation-pairing-score
…putation-qos-score-aggregation
…5-reputation-pairing-score
feat: Reputation: CNS-1006 - Reputation queries
feat: Reputation: CNS-1005 - Reputation pairing score
| @@ -67,10 +68,15 @@ func (k msgServer) RelayPayment(goCtx context.Context, msg *types.MsgRelayPaymen | |||
| addressEpochBadgeMap[mapKey] = badgeData | |||
| } | |||
| } | |||
| if _, ok := sessionRelaysAmount[relay.SessionId]; !ok { | |||
There was a problem hiding this comment.
each "relay" is not really one relay of one message, it is an aggregation of relays, could be 1 or 1000 relays so this is not accurate.
the most we can do now is use CU as weight or add to the proto msg the number of relays under the "relay"
There was a problem hiding this comment.
done. see 062ae0d
…putation-qos-score-aggregation
Description
Closes: #XXXX
In this PR I implemented the QoS excellence epoch score aggregation, done in the relay payment mechanism.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...