Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT - add provider verification probing data #1911

Merged
merged 26 commits into from
Feb 3, 2025

Conversation

ranlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Jan 15, 2025

Test Results

2 516 tests  +125   2 516 ✅ +126   25m 48s ⏱️ -53s
  123 suites +  2       0 💤 ±  0 
    7 files   +  1       0 ❌  -   1 

Results for commit 924892c. ± Comparison against base commit a470651.

♻️ This comment has been updated with latest results.

protocol/rpcprovider/testing.go Outdated Show resolved Hide resolved
shleikes
shleikes previously approved these changes Jan 16, 2025
@ranlavanet ranlavanet requested a review from shleikes January 21, 2025 16:39
@ranlavanet ranlavanet self-assigned this Jan 29, 2025
@ranlavanet ranlavanet requested a review from oren-lava January 30, 2025 14:52
oren-lava
oren-lava previously approved these changes Jan 30, 2025
@ranlavanet ranlavanet requested a review from oren-lava February 2, 2025 17:46
@ranlavanet ranlavanet merged commit e06adcc into main Feb 3, 2025
29 checks passed
@ranlavanet ranlavanet deleted the PRT-add-provider-verification-probing-data branch February 3, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants