Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create typopgraphy styled components from existing options #588

Merged
merged 1 commit into from
May 1, 2024

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Apr 27, 2024

Notes for Reviewers

This PR fixes #582

Task:

  • Export the custom typography for use before merging this PR in
  • Can add others if there are anything missing, but with the styled components using describe each of the variant as an alternative, in addition to changing the variant inline, this can help with defining the base styled typography component to use from

Signed commits

  • Yes, I signed my commits.

Example of what it could look, this is bare with the current palette from Sistent and using the styled component for each of the variant

Light Mode:
Screenshot from 2024-04-27 17-18-52

Dark Mode:
Screenshot from 2024-04-27 17-19-15

@nebula-aac nebula-aac marked this pull request as ready for review April 28, 2024 15:07
Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nebula-aac nebula-aac merged commit 0988d06 into master May 1, 2024
11 checks passed
@nebula-aac nebula-aac deleted the 582-typograhy-variants branch May 1, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create a custom Typography will use use the custom variant from texts
2 participants