Clean up loader #424
Merged
Clean up loader #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayHuLBL
approved these changes
Jan 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All loader functions now require a fully qualified Modelica class name, not a file path.
To find the corresponding Modelica JSON file, this class name is converted into a (relative) file path which is looked up for in the directories specified in
MODELICA_JSON_PATH.The function
prependToModelicaJsonPathin loader.ts can be used to register additional search paths for Modelica JSON files. It should only be used for testing. In production, the directories where Modelica JSON files are stored are known and do not require to be modified. Hence, there is no use for the previousprefixvariable which is removed with this PR.Related Issue(s)
#423
Testing
All server tests pass and
npm run parseTemplateJSONyields a valid templates.json file that can be used by client.