-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lmb 182 | can modify custom field #455
Draft
JonasVanHoof
wants to merge
21
commits into
karel/lmb-809-library-of-fields
Choose a base branch
from
lmb-182-can-modify-custom-field
base: karel/lmb-809-library-of-fields
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Lmb 182 | can modify custom field #455
JonasVanHoof
wants to merge
21
commits into
karel/lmb-809-library-of-fields
from
lmb-182-can-modify-custom-field
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVanHoof
changed the base branch from
karel/lmb-333-create-form-extensions
to
karel/lmb-809-library-of-fields
January 9, 2025 13:58
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
January 9, 2025 14:23
58d538b
to
0e49d6b
Compare
Rahien
force-pushed
the
karel/lmb-809-library-of-fields
branch
from
January 9, 2025 14:49
ecfa31e
to
1658d8c
Compare
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
January 9, 2025 15:08
221ac0d
to
09bf43a
Compare
JonasVanHoof
commented
Jan 9, 2025
Comment on lines
1
to
-2
{{#unless this.removed}} | ||
{{#if @inline}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the @inline
still needed here as I removed it with my rebase..
…to show this as a number for the DEMO 10/01/2025
…depending onj the action
…stom field button
JonasVanHoof
force-pushed
the
lmb-182-can-modify-custom-field
branch
from
January 10, 2025 14:50
27658c0
to
3f1b671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want the user to edit the custom form field. Adding an edit icon that opens a modal with the editable fields.
How to test
Edit a custom field in the mandataris extra info card
Links to other PR's
Attachments