Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lmb 182 | can modify custom field #455

Draft
wants to merge 21 commits into
base: karel/lmb-809-library-of-fields
Choose a base branch
from

Conversation

JonasVanHoof
Copy link
Contributor

@JonasVanHoof JonasVanHoof commented Jan 9, 2025

Description

We want the user to edit the custom form field. Adding an edit icon that opens a modal with the editable fields.

How to test

Edit a custom field in the mandataris extra info card

Links to other PR's

Attachments

@JonasVanHoof JonasVanHoof self-assigned this Jan 9, 2025
@JonasVanHoof JonasVanHoof changed the base branch from karel/lmb-333-create-form-extensions to karel/lmb-809-library-of-fields January 9, 2025 13:58
@JonasVanHoof JonasVanHoof force-pushed the lmb-182-can-modify-custom-field branch from 58d538b to 0e49d6b Compare January 9, 2025 14:23
@Rahien Rahien force-pushed the karel/lmb-809-library-of-fields branch from ecfa31e to 1658d8c Compare January 9, 2025 14:49
@JonasVanHoof JonasVanHoof force-pushed the lmb-182-can-modify-custom-field branch from 221ac0d to 09bf43a Compare January 9, 2025 15:08
app/components/rdf-input-fields/custom-field-wrapper.hbs Outdated Show resolved Hide resolved
app/components/rdf-input-fields/custom-field-wrapper.js Outdated Show resolved Hide resolved
Comment on lines 1 to -2
{{#unless this.removed}}
{{#if @inline}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the @inline still needed here as I removed it with my rebase..

@JonasVanHoof JonasVanHoof force-pushed the lmb-182-can-modify-custom-field branch from 27658c0 to 3f1b671 Compare January 10, 2025 14:50
@JonasVanHoof
Copy link
Contributor Author

Added the order from Karels PR in here
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant