Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run needless patreon auth checks #10136

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Do not run needless patreon auth checks #10136

merged 6 commits into from
Sep 5, 2024

Conversation

Thodor12
Copy link
Contributor

A large majority of players will likely never even have subscribed to Patreon, hence we can try to reduce network traffic on our servers by simply not allowing the mod to make a call to our auth system.
If players do want to play with features enabled, they will have to turn on the config value in the server config in order to start running these checks again.

This is merely a proposal, if we don't want this I'll remove it again.

The secondary check I added is something that prevents running the auth check again if features were previously unlocked already, that should also result in unnecessary calls being removed upon secondary opening of the town hall GUI.
(It seems highly unlikely that a Patreon subscription would expire in the middle of a session)

[X] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

@someaddons
Copy link
Contributor

It has to auto enable for the patreons :)

Copy link
Member

@Nightenom Nightenom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly should run once during mod loading but whatever

@Raycoms
Copy link
Contributor

Raycoms commented Sep 5, 2024

Honestly should run once during mod loading but whatever

We don't do that, so that people that sign up to patreon don't have to relog to get the stuff.

@Raycoms Raycoms merged commit 8d716e4 into ldtteam:version/main Sep 5, 2024
5 checks passed
Raycoms pushed a commit that referenced this pull request Sep 5, 2024
Do not run needless patreon auth checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants