Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix university in 1.21 #10142

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix university in 1.21 #10142

merged 3 commits into from
Aug 20, 2024

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Aug 20, 2024

Changes proposed in this pull request:

  • Fixes the research window not opening at all in 1.21.
  • Sorts the Item NBT datagen keys so that they stop swapping around each datagen.
  • Breaking: modifies the research data format to use SizedIngredient rather than our own hand-rolled types, producing simpler code and JSON.

[x] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please (do not backport)

@Raycoms Raycoms merged commit f97fb99 into version/1.21 Aug 20, 2024
5 checks passed
@Raycoms Raycoms deleted the fix/university branch August 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants