Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add game Knights and Knaves by JadAbouHawili #287

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jan 26, 2025

@joneugster joneugster added the New Game Request to add new game to the landing page label Jan 26, 2025
@TentativeConvert
Copy link
Collaborator

Looks neat and thought-through to me. I especially like the conversion table unicode symbols <-> keyboard available in the inventory under definitions.

@JadAbouHawili: World 3, level 1 switches to editor mode, and so do some of the later levels. Is that intended? If not, perhaps fix this first?

@joneugster
Copy link
Collaborator Author

In that case I'll way for @JadAbouHawili to build and upload a version without copilot as discussed an then I'll see that it gets on the front page by tomorrow night. Thanks for the contribution😊

@joneugster joneugster merged commit 39d7af9 into main Jan 27, 2025
2 checks passed
@JadAbouHawili
Copy link
Contributor

Looks neat and thought-through to me. I especially like the conversion table unicode symbols <-> keyboard available in the inventory under definitions.

@JadAbouHawili: World 3, level 1 switches to editor mode, and so do some of the later levels. Is that intended? If not, perhaps fix this first?

Didn't want the user to write have .. := by so I used Template which imposes editor mode, although @joneugster suggested something regarding have which I'm thinking about. I am also reconsidering other things about the game and will make improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Game Request to add new game to the landing page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants