feat: Detect undefined symbols #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current Python parser does not notice undefined symbols. While we don't do anything with them now, we want to pass that info back to the caller in the forthcoming linter. In addition, we intended parsing to fail when there are undefined symbols, as indicated in test_basic.py, but it was failing for an unrelated reason before, and broke a few commits ago. This change just makes a best effort attempt to notice undefined symbols, and crashes accordingly in the klr binary. In the future we will do more with this. This change fixes the broken CI build.
seanmcl
force-pushed
the
sm/undefined
branch
from
26b1bdb to
3f07df9
Compare
govereau
approved these changes
Feb 14, 2025
| @@ -221,14 +225,20 @@ def translate(self, src: str, line: int, f: types.FunctionType, args: ast.argume | |||
| # if we find other uses of potentially global names | |||
| # and fail to understand them; as long as we find and record | |||
| # the "real" uses into the environment for the Lean code. | |||
| def lookup(self, s): | |||
| return self.f.__globals__.get(s) or self.f.__builtins__.get(s) | |||
| def lookup(self, node): | |||
There was a problem hiding this comment.
Ok, nice. It was lookup.
| @@ -183,12 +183,16 @@ An example of a global is: | |||
| else: | |||
| ... | |||
| -/ | |||
| instance : Repr Lean.Json where | |||
| reprPrec jsn _ := jsn.compress | |||
| @@ -250,3 +260,13 @@ def visit_Attribute(self, node): | |||
| raise e | |||
| except Exception: | |||
| return | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
There was a problem hiding this comment.
I was thinking we might do: run_klr here?
There was a problem hiding this comment.
And then add a gather subcommand?
There was a problem hiding this comment.
Actually, not here. in wherever python -m klr-lang goes to.
There was a problem hiding this comment.
ooh good idea. Another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current Python parser does not notice undefined symbols. While we don't do anything with them now, we want to pass that info back to the caller in the forthcoming linter. In addition, we intended parsing to fail when there are undefined symbols, as indicated in test_basic.py, but it was failing for an unrelated reason before, and broke a few commits ago.
This change just makes a best effort attempt to notice undefined symbols, and crashes accordingly in the klr binary. In the future we will do more with this.
This change fixes the broken CI build.