Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing for python source functions #20

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Tracing for python source functions #20

merged 1 commit into from
Jan 22, 2025

Conversation

govereau
Copy link
Collaborator

@govereau govereau commented Jan 9, 2025

This patch adds basic tracing for user python functions. The main code
is in Python.lean, and depends on definitions in Basic.lean and
NKI.lean, which are incomplete. As more primitives are implemented,
more user kernels will be supported.

Note to reviewers: it may be helpful to check the tests in interop/tests/test_basic.py.

@govereau govereau added the enhancement New feature or request label Jan 9, 2025
@govereau govereau requested a review from seanmcl January 9, 2025 18:13
@govereau govereau self-assigned this Jan 9, 2025
@govereau govereau requested a review from jtristan as a code owner January 9, 2025 18:13
@govereau govereau changed the base branch from main to pg-basic January 9, 2025 18:14
NKL/Trace.lean Show resolved Hide resolved
NKL/Trace/NKI.lean Outdated Show resolved Hide resolved
NKL/Trace/Python.lean Outdated Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
NKL/Trace/Python.lean Outdated Show resolved Hide resolved
NKL/Trace/Python.lean Outdated Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
Base automatically changed from pg-basic to main January 11, 2025 16:19
Copy link
Collaborator

@seanmcl seanmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some unresolved comments from last time. If you want to punt them to the future just add some TODO comments and I'll approve.

NKL/Trace.lean Show resolved Hide resolved
NKL/Trace/Basic.lean Outdated Show resolved Hide resolved
NKL/Trace/NKI.lean Show resolved Hide resolved
NKL/Trace/Python.lean Outdated Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
NKL/Trace/Python.lean Show resolved Hide resolved
interop/test/test_basic.py Show resolved Hide resolved
interop/test/test_basic.py Show resolved Hide resolved
This patch adds basic tracing for user python functions. The main code
is in Python.lean, and depends on definitions in Basic.lean and
NKI.lean, which are incomplete. As more primitives are implemented,
more user kernels will be supported.
@govereau govereau merged commit 8757026 into main Jan 22, 2025
1 check passed
@govereau govereau deleted the pg-trace branch January 22, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants