-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BitVec multiplication simp lemmas #6718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad902
commented
Jan 20, 2025
This is rows 181/182 of the spreadsheet. |
Mathlib CI status (docs):
|
kim-em
reviewed
Jan 21, 2025
kim-em
reviewed
Jan 21, 2025
kim-em
reviewed
Jan 21, 2025
vlad902
commented
Jan 22, 2025
kim-em
approved these changes
Jan 29, 2025
@vlad902 if you fix the merge conflict we can merge this. |
This PR adds BitVec lemmas required to cancel multiplicative negatives, and plumb support through to bv_normalize to make use of this result in the normalized twos-complement form. I include some bmod lemmas I found useful to prove this result, the two helper lemmas I add use the same naming/proofs as their emod equivalents.
vlad902
added a commit
to vlad902/lean4
that referenced
this pull request
Jan 30, 2025
As a follow-up to leanprover#6718, refactor a few bmod proofs to be shorter and exactly match their emod* equivalents for uniformity.
vlad902
added a commit
to vlad902/lean4
that referenced
this pull request
Jan 30, 2025
As a follow-up to leanprover#6718, refactor a few bmod proofs to be shorter and exactly match their emod* equivalents for uniformity.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
As a follow-up to #6718, refactor a few bmod proofs to be shorter and exactly match their emod* equivalents for uniformity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-language
Language features, tactics, and metaprograms
P-medium
We may work on this issue if we find the time
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BitVec lemmas required to cancel multiplicative negatives, and plumb support through to bv_normalize to make use of this result in the normalized twos-complement form.
I include some bmod lemmas I found useful to prove this result, the two helper lemmas I add use the same naming/proofs as their emod equivalents.