Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
BitVec.(getElem_umod_of_lt, getElem_umod, getLsbD_umod, getMsbD_umod)
#6795base: master
Are you sure you want to change the base?
feat: add
BitVec.(getElem_umod_of_lt, getElem_umod, getLsbD_umod, getMsbD_umod)
#6795Changes from 7 commits
2c3028e
2471a7b
c00e73c
f98c301
f1cc2a7
6cc0c58
39424b4
3504e69
04e1ccd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we reuse
getElem_umod_of_(lt/pos)
here? That lemmas seems to describe exactly this case, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it's actually interesting, using that theorem in the proof seems to only make the proof longer. I guess we don't need
getElem_umod_of_pos
in the first place.