Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add simple Ordering lemmas #6821

Merged
merged 8 commits into from
Jan 31, 2025
Merged

feat: add simple Ordering lemmas #6821

merged 8 commits into from
Jan 31, 2025

Conversation

datokrat
Copy link
Contributor

@datokrat datokrat commented Jan 28, 2025 •
edited
Loading

This PR adds basic lemmas about Ordering, describing the interaction of isLT/isLE/isGE/isGT, swap and the constructors. Additionally, it refactors the instance derivation code such that a LawfulBEq Ordering instance is also derived automatically.

Some of these lemmas are helpful for the TreeMap verification.

@datokrat datokrat added the changelog-library Library label Jan 28, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 28, 2025 15:22 Inactive
@datokrat datokrat marked this pull request as ready for review January 28, 2025 15:29
@datokrat datokrat requested a review from kim-em as a code owner January 28, 2025 15:29
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 28, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6821
04fa62d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6821
f52777a
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 28, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 28, 2025 •
edited
Loading

Mathlib CI status (docs):

@datokrat
Copy link
Contributor Author

datokrat commented Jan 28, 2025 •
edited
Loading

It seems that my PR "breaks" Batteries by simplifying a proof that expects goals to remain... Update: fixed on leanprover-community/batteries#1102

@datokrat datokrat mentioned this pull request Jan 29, 2025
Merged
TwoFX
TwoFX reviewed Jan 29, 2025
View reviewed changes
src/Init/Data/Ord.lean Outdated Show resolved Hide resolved
src/Init/Data/Ord.lean Outdated Show resolved Hide resolved
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
c867064
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
f7f81af
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 29, 2025 08:58 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 29, 2025 09:11 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
c00be7c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
d41dd2f
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Jan 30, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 30, 2025 16:13 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 30, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
0fc3fe9
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 30, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6821
19ae301
@TwoFX TwoFX added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit ad48761 Jan 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX approved these changes

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datokrat @leanprover-community-bot @TwoFX