Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add or/and/xor lemmas for BitVec/bv_normalize #6872

Merged
merged 5 commits into from
Jan 31, 2025
Merged

feat: add or/and/xor lemmas for BitVec/bv_normalize #6872

merged 5 commits into from
Jan 31, 2025

Conversation

vlad902
Copy link
Contributor

@vlad902 vlad902 commented Jan 30, 2025 •
edited
Loading

This PR adds lemmas for xor injectivity and when and/or/xor equal allOnes or zero. Then I plumb support for the new lemmas through to bv_normalize.

@vlad902
feat: teach bv_normalize about or/xor equals 0
e25642d 
This PR adds lemmas for xor injectivity and when and/or/xor equal
allOnes or zero. Then I plumb through support for or/xor equals 0 to
bv_normalize.
@vlad902
Copy link
Contributor Author

vlad902 commented Jan 30, 2025

changelog-library

@github-actions github-actions bot added the changelog-library Library label Jan 30, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 30, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 30, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2fedd7144aff67f65ee95736d6fa8a1f9319ebc4 --onto e922edfc218090ab2e54092336c67fe3b970dfc2. (2025-01-30 17:58:17)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2fedd7144aff67f65ee95736d6fa8a1f9319ebc4 --onto ad48761032c5750e51289f3885967c1b6f8edde5. (2025-01-31 12:49:41)

@vlad902 vlad902 requested a review from hargoniX January 30, 2025 22:43
@vlad902 vlad902 changed the title feat: teach bv_normalize about or/xor equals 0 feat: add or/and/xor lemmas for BitVec/bv_normalize Jan 31, 2025
@hargoniX hargoniX added this pull request to the merge queue Jan 31, 2025
@hargoniX hargoniX removed this pull request from the merge queue due to a manual request Jan 31, 2025
@hargoniX hargoniX added this pull request to the merge queue Jan 31, 2025
Merged via the queue into leanprover:master with commit 7bd12c7 Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad902 @leanprover-community-bot @hargoniX