Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for unused v4 input features #104

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

zyhu-hu
Copy link
Collaborator

@zyhu-hu zyhu-hu commented Feb 3, 2025

add a clarification in the online testing section that previous step's scalar features and location index should not be used in training, since they are not supported in E3SM implementation yet.

@zyhu-hu zyhu-hu requested a review from jerrylin96 February 3, 2025 20:05
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.41%. Comparing base (b35af31) to head (936e166).
Report is 37 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #104      +/-   ##
========================================
- Coverage   6.72%   6.41%   -0.32%     
========================================
  Files          1       1              
  Lines        847     982     +135     
========================================
+ Hits          57      63       +6     
- Misses       790     919     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jerrylin96 jerrylin96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zeyuan! Adding this to climsim3 as well.

@jerrylin96 jerrylin96 merged commit 32ece32 into leap-stc:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants