Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional icons needed for 0.18 coach category modal #919

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Jan 31, 2025

Description

This PR updates the icon library to include several new icons needed to support coach resource discovery work in 0.18 Kolibri - specifically adding highest-level category icons that are required in the coach search and filter experience

Issue addressed

Closes #915

New icons

As previewed on the documentation page (deploy preview)

Description Icon
autoReplace Screenshot 2025-02-04 at 5 13 27 PM
basicSkillsResource Screenshot 2025-02-04 at 5 13 23 PM
circleCheckmark Screenshot 2025-02-04 at 5 12 22 PM
optionsCircle Screenshot 2025-02-04 at 5 12 38 PM
dailyLifeResource Screenshot 2025-02-04 at 5 13 16 PM
forTeachersResource Screenshot 2025-02-04 at 5 12 57 PM
schoolResource Screenshot 2025-02-04 at 5 13 11 PM

Changelog

  • Description: Additional category icons are now available
  • Products impact: -
  • Addresses: -
  • Components: KIcon
  • Breaking: No
  • Impacts a11y: No
  • Guidance: New icons can now be used

Steps to test

Confirm the list of icons is rendering correctly on the documentation page and are available as KIcons in the documentation preview

Comments

Reference for the process for generating these files is in the dev docs on the icons.md page

@marcellamaki marcellamaki force-pushed the add-0.18-kolibri-category-icons branch from e5197a9 to 32d8f35 Compare February 4, 2025 21:59
@marcellamaki marcellamaki marked this pull request as ready for review February 4, 2025 22:18
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcellamaki! Looks good to me!

@AlexVelezLl AlexVelezLl merged commit c08b45b into learningequality:develop Feb 5, 2025
11 of 12 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Feb 5, 2025
@AlexVelezLl AlexVelezLl mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add 0.18 icons
2 participants