Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for group filter with no groups #284

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix error for group filter with no groups #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc2bbdb
Fix error for group filter with no groups
Oct 19, 2023
e337e6a
bump version for release update
Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions classes/ratings_and_allocations_table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,8 @@ function($o) {
},
$this->groupsofallchoices)))) {
$sql .= "," . $gmgroupid . ") ) ";
} else {
$sql .= "))";
}
} else if ($this->groupselect != 0) {
$sql .= "AND u.id in ( SELECT gm.userid FROM {groups_members} gm WHERE gm.groupid= :groupselect ) ";
Expand Down
2 changes: 1 addition & 1 deletion version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2023101700; // The current module version (Date: YYYYMMDDXX).
$plugin->version = 2023101900; // The current module version (Date: YYYYMMDDXX).
$plugin->requires = 2020061500; // Requires Moodle 3.9+.
$plugin->maturity = MATURITY_STABLE;
$plugin->release = 'v4.3-r1';
Expand Down