Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch python2 #216

Merged
merged 58 commits into from
Aug 28, 2023
Merged

Ditch python2 #216

merged 58 commits into from
Aug 28, 2023

Conversation

league
Copy link
Collaborator

@league league commented Jul 20, 2023

This was a branch, but I just updated it from master and started a PR to more easily see and discuss changes.

(I was about to delete some __future__ stuff when I remembered to look for this branch.)

@league
Copy link
Collaborator Author

league commented Jul 21, 2023

I think all of the clean-ups in #178 are here now, except the ones that are more complicated:

  • removing block.py
  • ring vs ring2

But commits in this PR (or that previously made it to master) include these clean-ups:

  • remove dtype.py
  • pypy stuff
  • commented-out code in ring.py
  • remove test_fft.cu

…in addition to the Python2 cleanups.

@jaycedowell
Copy link
Collaborator

I recall problems when I tried to remove block.py but I don't remember exactly what they were. It's a shame that those logs from #178 have expired and been removed.

@jaycedowell jaycedowell mentioned this pull request Jul 21, 2023
@jaycedowell
Copy link
Collaborator

When I was working on 8cff5c2 I noticed that there was another Python2-ism buried in test_scripts.py. There might be other things labeled as "Python2 catch" in the code, specifically related to bytes -> str -> bytes conversion that were missed.

@league league marked this pull request as ready for review August 16, 2023 19:25
@league league requested a review from jaycedowell August 16, 2023 19:26
@jaycedowell
Copy link
Collaborator

jaycedowell commented Aug 22, 2023

Should we put a "needs Python 3.6+" message somewhere? That's the only thing I can thing of that this might be missing.

Added in b5f503a.

@jaycedowell
Copy link
Collaborator

jaycedowell commented Aug 25, 2023

Should we also change configure to check if Python is >=3.6?

Add in e01355f.

Copy link
Collaborator

@jaycedowell jaycedowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed most of the things that I noticed but there are a couple left.

tools/like_ps.py Show resolved Hide resolved
tools/pipeline2dot.py Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@jaycedowell
Copy link
Collaborator

That's everything now.

@jaycedowell jaycedowell merged commit 77eb32e into master Aug 28, 2023
@jaycedowell jaycedowell deleted the no_python2 branch August 28, 2023 22:57
jaycedowell added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants