Bugfix for stray bass and broken channel volume

leecher1337 · Sep 27, 2023 · 5ab89a4 · 5ab89a4
1 parent dc95b62
commit 5ab89a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -185,6 +185,10 @@ Documentation
 
 [ESSPlayMid native ASM reference implementation](https://github.com/pachuco/ESSPlayMid)
 
+[Mirror of ESS drivers from the manufacturer](https://www.zx.net.nz/mirror/www.esstech.com/techsupp/drivers.html)
+
+[List of ESS soundcards](https://dosdays.co.uk/topics/Manufacturers/ess.php)
+
 Driver is based on SB16 NTDDK driver sample and may contain some leftovers 
 from it.
 

diff --git a/src/win2k/NATV.cpp b/src/win2k/NATV.cpp
@@ -448,7 +448,7 @@ void NATV_CalcNewVolume(BYTE bChannel)
         if ((voice->flags1 & VOICEFLAG_SETUP) && (voice->bChannel == bChannel || bChannel == 0xFF)) 
         {
             for (j=0; j < OPS_PER_CHAN; j++)
-                fmwrite(i * 32 + j * 8 + 1, NATV_CalcVolume(voice->reg1[j], (voice->bVelocity & 3), voice->bChannel));
+                fmwrite(i * 32 + j * 8 + 1, NATV_CalcVolume(voice->reg1[j], (voice->bVelocity >> (j*2)) & 3, voice->bChannel));
         }
     }   
 }
@@ -735,7 +735,7 @@ void  setup_operator(
     {
         transpose = ((((gBankMem[offset + 5]) << 2) & 0x7F) | (gBankMem[offset + 4] & 3));
         if (gBankMem[offset + 5] & 0x10) // signed?
-            transpose *= -1;
+            transpose |= ~0x7F;
         note += transpose;
     }