Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update dependencies #647

Merged
merged 1 commit into from
Jan 18, 2025
Merged

⬆️ update dependencies #647

merged 1 commit into from
Jan 18, 2025

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jan 18, 2025

This pull request includes various updates and improvements to the chopper and chopper_generator packages, focusing on code formatting, dependency updates, and minor refactoring. Below are the most important changes:

Code Formatting

  • Added a comment to specify the dart format width in several generated files to ensure consistent code formatting. [1] [2] [3] [4] [5] [6] [7]

Dependency Updates

  • Updated the qs_dart dependency from version 1.2.3 to 1.3.0 in chopper/pubspec.yaml.
  • Updated the analyzer dependency to ">=6.9.0 <8.0.0" and source_gen dependency to ">=1.5.0 <3.0.0" in chopper_generator/pubspec.yaml. Removed the dart_style dependency.

Codebase Simplification

  • Removed the dart_style import and associated formatting logic in chopper_generator/lib/src/generator.dart. [1] [2]
  • Refactored the _factoryForFunction and _getResponseInnerType methods in chopper_generator/lib/src/generator.dart for better readability and maintainability. [1] [2]

Code Annotations

  • Added // ignore: must_be_immutable annotation to the Request class in chopper/lib/src/request.dart to suppress immutability warnings.

Supersedes #646

@techouse techouse added the dependencies Pull requests that update a dependency file label Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (c4e29ed) to head (5591511).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #647   +/-   ##
========================================
  Coverage    93.38%   93.38%           
========================================
  Files           21       21           
  Lines          499      499           
========================================
  Hits           466      466           
  Misses          33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techouse techouse added the dart Pull requests that update Dart code label Jan 18, 2025
@techouse techouse merged commit cf8e7c7 into develop Jan 18, 2025
6 checks passed
@techouse techouse deleted the chore/updates branch January 18, 2025 00:35
@techouse techouse added this to the 8.0.4 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants