Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #348 by deleting auto-generated sqlite_stat tables. #351

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/reader/_storage/_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,18 @@ def disable(self) -> None:
# However, we at least minimize the space they take using VACUUM.

if self.path:
# Delete any internal tables that may have been created with
# ANALYZE or indirectly via PRAGMA OPTIMIZE.
#
# For more information, see:
# - https://github.com/lemon24/reader/issues/348
# - https://sqlite.org/forum/forumpost/5414ca8f89389f8a
db.execute("DROP TABLE IF EXISTS search.sqlite_stat1;")
db.execute("DROP TABLE IF EXISTS search.sqlite_stat2;")
db.execute("DROP TABLE IF EXISTS search.sqlite_stat3;")
db.execute("DROP TABLE IF EXISTS search.sqlite_stat4;")

# Now the database should be empty. VACUUM to reclaim space.
db.execute("VACUUM search;")

@classmethod
Expand Down